Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semi-colon vs colon #34

Open
arademaker opened this issue Feb 6, 2023 · 4 comments
Open

semi-colon vs colon #34

arademaker opened this issue Feb 6, 2023 · 4 comments

Comments

@arademaker
Copy link
Member

arademaker commented Feb 6, 2023

we have cases were semi-colon were used instead of colon. The complete list of manually analyzed cases done by the @fcbond team is https://github.com/own-pt/glosstag/blob/master/scripts/issue-34.xml

arademaker added a commit that referenced this issue Feb 6, 2023
arademaker added a commit that referenced this issue Feb 6, 2023
1. the issue-34.txt was transformed into a valid XML and renamed to
   issue-34.xml

2. the comment in the last line about the synset 04203889-n I had
   already applied in the data/ann/annotation-XX.jl

3. the synsets that I manually fixed in data/ann/annotation-XX.jl I
   removed from the issue-34.xml
@arademaker
Copy link
Member Author

@fcbond I converted the issue-34.txt to scripts/issue-34.xml. This is now a valid XML. Maybe you can help me with the not so easy cases? I would be enough to have and extra xxx with the desire fix in each synset. So I do not introduce any error. See the last synset in the file.

note also the comments in my last commit. From your file, I removed the last lines because that error I had already fixed.

------------------------------------------------------------------------
Also:

2. shopping -- (the commodities purchased from stores; "she loaded her shopping into the car"women carrying home shopping didn't give me a second glance")

Finally, the 3 or 4 cases that I manually fixed today I also removed from the scripts/issue-34.xml

arademaker added a commit that referenced this issue Feb 6, 2023
adding the suggestions of changes.
arademaker added a commit that referenced this issue Feb 7, 2023
1. two cases from #34
2. removed inconsistencies of two cases
arademaker added a commit that referenced this issue Feb 7, 2023
@fcbond
Copy link
Collaborator

fcbond commented Feb 9, 2023

I have added suggestions to all the sentences in https://github.com/own-pt/glosstag/blob/master/scripts/issue-34.xml

I'm going to refer to this issue in Open English Wordnet: the cases @arademaker fixed manually are commit f3bdc66 and commit 59ed6d4

@arademaker
Copy link
Member Author

Hi @fcbond, maybe you forgot to make a PR or push the commits to GitHub? I can't see the changes.

arademaker added a commit that referenced this issue Feb 10, 2023
four more glosses were fixed
@jmccrae
Copy link

jmccrae commented Jun 6, 2023

Small comment when implementing this for OEWN. For 11909048-n, the term 'Northern Hemisphere' should be capitalized

erect or climbing herbs of the Northern Hemisphere and southern Africa: bleeding heart, Dutchman's breeches, fumitory, squirrel corn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants