Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Multi-Personal (1st round) #4527

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[FEATURE REQUEST] Multi-Personal (1st round) #4527

wants to merge 11 commits into from

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Dec 20, 2024 •
edited
Loading

Related Issues

App: #4514

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 requested a review from joragua December 20, 2024 13:26
@JuancaG05 JuancaG05 force-pushed the feature/multi_personal1 branch 2 times, most recently from 590f6e4 to 4357850 Compare January 7, 2025 09:56
@JuancaG05 JuancaG05 linked an issue Jan 8, 2025 that may be closed by this pull request
[FEATURE REQUEST] Multi-Personal (1st round) #4514
Open
9 tasks
joragua
joragua reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @JuancaG05!! Only two comments and it's done 😄

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListAdapter.kt Outdated Show resolved Hide resolved
...mLibrary/src/main/java/com/owncloud/android/lib/resources/spaces/responses/SpacesResponse.kt Show resolved Hide resolved
@JuancaG05 JuancaG05 force-pushed the feature/multi_personal1 branch from 5fb1724 to cde5496 Compare January 9, 2025 17:26
@JuancaG05 JuancaG05 requested a review from joragua January 9, 2025 17:28
joragua
joragua approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready for QA 🚀 (Don't forget to rebase the branch with master. Just a reminder)

@JuancaG05 JuancaG05 force-pushed the feature/multi_personal1 branch from cde5496 to bbd8a5a Compare January 10, 2025 07:31
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 10, 2025 •
edited
Loading

QA checks:

enforce_oidc is false

  • Regular oCIS server -> correct authentication & authorization
  • Server with only OIDC -> error (shows basic auth credential fields)
  • Basic auth -> correct authentication & authorization
  • OAuth2 -> correct authentication & authorization

enforce_oidc is true

  • Regular oCIS server -> correct authentication & authorization (uses OIDC)
  • Server with only OIDC -> correct authentication & authorization
  • Basic auth -> moved to browser
  • OAuth2 -> correct authentication & authorization

new path field

  • oauth2_redirect_uri_path is empty
  • oauth2_redirect_uri_path is not empty

Spaces:

  • Multiple personal spaces (kws server) -> Personal tab empty, list in Spaces tab
  • Just one (oC) -> Personal with content

Regression:

  • Regression: E2E passed

@JuancaG05
feat: consider share_jail in capabilities non-required
df99718
@JuancaG05
feat: consider lastModifiedDateTime, webUrl and driveAlias in s…
3e43699 
…paces non-required
@JuancaG05
feat: add new has_multiple_personal_spaces capability and use it to…
72949f9 
… mock a default quota for multi-personal accounts
@JuancaG05
feat: retrieve only personal spaces in multi-personal accounts
96b5ab5
@JuancaG05
feat: show spaces header in personal spaces only in multi-personal ac…
582f9d2 
…counts
@JuancaG05
feat: show correct toolbar and apply correct navigation in personal s…
dcb65f6 
…paces of multi-personal accounts
@JuancaG05
feat: not showing space header in "Av. offline" tab
b5ab511
@JuancaG05
fix: added missing parameter in CapabilityViewModel unit tests
d68e645
@JuancaG05
chore: added calens file
64435db
@JuancaG05
refactor: removed unnecessary type declaration in variable
ca29365
@JuancaG05 JuancaG05 force-pushed the feature/multi_personal1 branch from bbd8a5a to ca29365 Compare January 10, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joragua joragua joragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Multi-Personal (1st round)
3 participants
@JuancaG05 @jesmrec @joragua