Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #1038

Closed
wants to merge 63 commits into from
Closed

Spelling #1038

wants to merge 63 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Sep 15, 2021

Description

This PR corrects misspellings identified by the check-spelling action.

Related Issue

Motivation and Context

How Has This Been Tested?

The misspellings have been reported at jsoref@283055f#commitcomment-56526425

The action reports that the changes in this PR would make it happy: jsoref@01582cf

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@jsoref
spelling: activity
6687376 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: amount
ab782b6 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: appearance
5783d3d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: assets
91702d8 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: attachments
c3a1e18 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: been
2cce482 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: behavior
b8a4a26 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: bookmark
df18fee 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: button
9ad27c4 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: cellular
c110b22 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: coalescing
2a7db8f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: collation
f2a11f9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: collision
b086cd9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: committed
8275514 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: concerning
cbf0827 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: controller
76b94bf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: current
6c94e9c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: decision
a60764b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: delegate
b36dca5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: deletable
b422f2c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: delimiters
0044d69 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: description
72d256f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: discretion
d31b65f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: environment
080d363 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: ephemeral
0e4563b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: extension
e6e3938 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: global
75229e7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: icipc
8e2ca3a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: including
6dfe74b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: interfere
49da494 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: populated
30c9bf7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: portrait
21cc951 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: preferably
99e5b16 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: product
ceb75e3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: recipient
6d3f5bf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: repositories
946577e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: resource
13effc1 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: resources
8d67c56 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: results
e2c28ad 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: search
771f80b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: settings
ad786bb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: several
56350fe 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: suppress
321f63f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: themable
73d7686 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: theming
eb2198c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: thumbnails
7e3ed64 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: toggle
2d6eb2f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unencrypted
3ab5a86 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unfortunately
98caf6b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: unusable
1d564ee 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: version
cbdf50a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: whether
8da0dbf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: workaround
bb6eb45 
Signed-off-by: Josh Soref <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jsoref
jsoref commented Sep 15, 2021
View reviewed changes
Copy link
Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look back next week (including fixing the item I flagged here).

I can generally split things as requested. The default commit strategy makes it easy for me to rebase (I have 5 owncloud repos staged, and at least 2 of them ended up w/ merge conflicts between my start and looking now) or to drop changes if they're objectionable (e.g. them*).

ownCloud/UI Elements/CollapsibleProgressBar.swift
@@ -224,7 +224,7 @@ class CollapsibleProgressBar: UIView, Themeable {
self.collapse(doAutoCollapse, animate: true)
}

// MARK: - Update coalescating
// MARK: - Update coalescing
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all sure what this is

ownCloudAppFramework/Licensing/Manager/OCLicenseManager.m
@@ -799,7 +799,7 @@ - (void)_rebuildFromProvidersWithCompletionHandler:(dispatch_block_t)completionH
}
}

#pragma mark - Update coalescation
#pragma mark - Update collation
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all sure what this is

ownCloudAppShared/AppLock/PasscodeViewController.swift
public class PasscodeViewController: UIViewController, Themeable {
public class PasscodeViewController: UIViewController, Themable {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both spellings are sprinkled throughout this codebase. I don't have a particular preference

ownCloudAppShared/User Interface/Theme/UI/ThemeableColoredView.swift
@@ -1,5 +1,5 @@
//
// ThemeableColoredView.swift
// ThemableColoredView.swift
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to rename the file.

@hosy hosy closed this Sep 24, 2024
@jsoref
Copy link
Author

jsoref commented Sep 24, 2024

@hosy was there anything I could do to help get some subset of this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstingl michaelstingl Awaiting requested review from michaelstingl

@felix-schwarz felix-schwarz Awaiting requested review from felix-schwarz

@hosy hosy Awaiting requested review from hosy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @CLAassistant @hosy