-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning in case the server cuts out auth header #221
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
============================================
- Coverage 68.77% 68.72% -0.05%
- Complexity 228 229 +1
============================================
Files 35 35
Lines 903 905 +2
============================================
+ Hits 621 622 +1
- Misses 282 283 +1
Continue to review full report at Codecov.
|
Code looks fine. |
@jvillafanez could you be a bit more specific on what I need to improve. You want me to rename As for now I just added a clue to the issue I had with a phoenix so nobody else will stuck at the same point. |
cecf65f
to
edc2ceb
Compare
6b0e450
to
d931388
Compare
That's partially yes. I'd prefer to have just one endpoint to perform sanity / health checks instead of end up with multiple endpoints for this matter. |
Ping, any update on this? |
9755dd5
to
ef61fff
Compare
0f53615
to
4509594
Compare
any update? |
Other than rebasing to update the code, I think this is ready. Anything left to do @VicDeo |
💥 Acceptance tests pipeline webUIOauth2-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
@phil-davis mind to have a look why the build was killed...? |
💥 Acceptance tests pipeline webUIOauth2-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
Rebased |
💥 Acceptance tests pipeline webUIOauth2-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline webUIOauth2-latest-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline webUIOauth2-master-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
While on Admin Settings page end an ajax request and show a warning if the Authorization header is stripped by the webserver