Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]add edge case for check file info #10091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR add tests for edge cases
Screenshot from 2024-09-18 13-08-08

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

sonarcloud bot commented Sep 18, 2024

* @return void
* @throws GuzzleException
*/
public function userTriesToCheckTheInformationOfDeletedFileUsingWopiEndpoint(string $user):void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function userTriesToCheckTheInformationOfDeletedFileUsingWopiEndpoint(string $user):void {
public function userGetsTheFileInformationUsingWopiEndpoint(string $user):void {

or something like this

Comment on lines +611 to +612
When user "Alice" tries to get the file information of file using wopi endpoint
Then the HTTP status code should be "500"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check the JSON response if it returns any response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants