Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add tests for create link on project spaces resources #9044

Merged

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented May 2, 2024

Description

This PR add tests coverage for share-ng endpoint to create share link on project space drive

Scenario Outline: create a share link of a folder inside project-space
Scenario: create an internal link share of a folder inside project-space
Scenario: try to create an internal share link of a folder inside project-space with password
Scenario Outline: create a share link of a folder inside project-space with display name and expiry date
Scenario Outline: create a share link of a folder inside project-space with a password that is listed in the Banned-Password-List
Scenario: set password on a existing share link of a folder inside project-space
Scenario Outline: create a share link of a file inside project-space without password
Scenario Outline: create a share link of a file inside project-space
Scenario: create an internal share link of a file inside project-space
Scenario: try to create an internal share link of a file inside project-space with password from project-space
Scenario Outline: create a share link of a file inside project-space with display name and expiry date
Scenario Outline: create a share link of a file inside project-space without password
Scenario Outline: create a share link of a file inside project-space with a password that is listed in the Banned-Password-List
Scenario: set password on a existing share link of a file inside project-space

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-create-share-link-on-project-spaces branch from 43303dd to 2e0b57c Compare May 3, 2024 11:23
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@amrita-shrestha amrita-shrestha merged commit 738a268 into master May 6, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-create-share-link-on-project-spaces branch May 6, 2024 06:12
| blocksDownload |


Scenario: create an internal link share of a folder inside project-space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please expand this scenario for this #8960

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be done in #9046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants