Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test for removing link share of a project space using permissions endpoint #9246

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented May 24, 2024

Description

This PR add tests coverage for share-ng endpoint to remove share link of a project space/drive using permissions endpoint

Scenario Outline: remove link share of a project drive using permissions endpoint
Scenario: user removes internal link share from project space using permissions endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this May 24, 2024
@nirajacharya2 nirajacharya2 force-pushed the remove-link-share-project-space-file branch 2 times, most recently from 05a8820 to 26aab31 Compare June 3, 2024 04:23
@nirajacharya2 nirajacharya2 force-pushed the remove-link-share-project-space-file branch from 26aab31 to c874dfd Compare June 4, 2024 05:37
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for deleting/removing share link of file and folder in project space using root endpoint [tests-only][full-ci] adding test for deleting/removing share link of file and folder in project space using permissions endpoint Jun 4, 2024
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for deleting/removing share link of file and folder in project space using permissions endpoint [tests-only][full-ci] adding test for deleting/removing share link of a project space using permissions endpoint Jun 4, 2024
@nirajacharya2 nirajacharya2 marked this pull request as ready for review June 7, 2024 06:32
@saw-jan saw-jan changed the title [tests-only][full-ci] adding test for deleting/removing share link of a project space using permissions endpoint [tests-only][full-ci] adding test for removing link share of a project space using permissions endpoint Jun 7, 2024
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to consistent wording

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirajacharya2 could you add using permission and root ... phrase in exisitng Scenario descriptions?

@nirajacharya2 nirajacharya2 force-pushed the remove-link-share-project-space-file branch from c874dfd to 3db6d84 Compare June 10, 2024 06:16
@nirajacharya2 nirajacharya2 force-pushed the remove-link-share-project-space-file branch from 3db6d84 to 71424fe Compare June 10, 2024 07:11
@nirajacharya2 nirajacharya2 force-pushed the remove-link-share-project-space-file branch from 71424fe to f0c4bb5 Compare June 13, 2024 03:57
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saw-jan saw-jan merged commit 0711579 into master Jun 13, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jun 13, 2024
…e-file

[tests-only][full-ci] adding test for removing link share of a project space using permissions endpoint
@nirajacharya2 nirajacharya2 deleted the remove-link-share-project-space-file branch June 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants