Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test for updating share link of a project space using permission endpoint #9251

Merged
merged 1 commit into from
May 31, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented May 24, 2024

Description

This PR add tests coverage for share-ng endpoint to update share link of a project space/drive

Scenario Outline: update link share of a project-space

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 force-pushed the update-link-share-project-space branch from 29f033e to 82d9ab3 Compare May 30, 2024 09:33
@nirajacharya2 nirajacharya2 force-pushed the update-link-share-project-space branch 2 times, most recently from 7ece058 to f19e78f Compare May 30, 2024 10:24
@nirajacharya2 nirajacharya2 force-pushed the update-link-share-project-space branch 2 times, most recently from a0958d4 to cac488d Compare May 31, 2024 03:29
@nirajacharya2 nirajacharya2 force-pushed the update-link-share-project-space branch from cac488d to 627319b Compare May 31, 2024 04:11
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirajacharya2 nirajacharya2 force-pushed the update-link-share-project-space branch from 627319b to 6b35bca Compare May 31, 2024 06:12
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 62076ad into master May 31, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update-link-share-project-space branch May 31, 2024 06:51
ownclouders pushed a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants