add secureview flag when listing apps via http #9277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
AlexAndBear
reviewed
May 29, 2024
AlexAndBear
previously requested changes
May 29, 2024
Co-authored-by: Alex <[email protected]>
|
Yep, collabora is the favorite and default |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
dismissed
AlexAndBear’s stale review
fixed typo and set default to collabora online
AlexAndBear
approved these changes
May 30, 2024
rhafer
approved these changes
May 30, 2024
|
Can you wait for cs3 and bump in this pr? |
|
sure |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
|
307 changed files? |
|
go back to your holiday! ;-) the reva bump pulled in the deps for the posix driver as well. |
ownclouders
pushed a commit
that referenced
this pull request
May 30, 2024
add secureview flag when listing apps via http
|
unfortunately secure_view flag is false in apps/list API |
|
Default value is wrong, should be Collabora not Collabora Online. |
This was referenced May 30, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow clients to see which application supports secure view we add a flag to the http response when the app name matches a configured secure view app. The app can be configured by setting
FRONTEND_APP_HANDLER_SECURE_VIEW_APPto the name of the app registered as a CS3 app provider.Part of #9272
Only effective when cs3org/reva#4703 got merged and reva bumped