Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-CI] adding test for updating share link of a resource in project space. #9297

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jun 3, 2024

Description

This PR add tests coverage for share-ng endpoint to update share link of a resource in project-space

Scenario Outline: update role of a folder's link share inside project-space using permissions endpoint
Scenario Outline: update role of a file's link share inside a project-space using permissions endpoint
Scenario Outline: update role of a file's link share to internal inside a project-space using permissions endpoint
Scenario Outline: update role of a folder's link share to internal inside project-space using permissions endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the update-link-share-project-space-file branch from df4a632 to e22605d Compare June 4, 2024 04:02
@prashant-gurung899 prashant-gurung899 force-pushed the update-link-share-project-space-file branch from e22605d to 3ebeadc Compare June 4, 2024 04:13
Comment on lines +3043 to +3044
| view | edit |
| edit | view |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason for limiting permissions-role to vie and edit only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was due to different JSON response for edit/view and internal permissions role. I have added new scenario for updating role of a file to internal.

@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-CI] adding test for updating share link of a file in project space. [tests-only][full-CI] adding test for updating share link of a resource in project space. Jun 4, 2024
@prashant-gurung899 prashant-gurung899 force-pushed the update-link-share-project-space-file branch from 3ebeadc to 6322a41 Compare June 4, 2024 09:50
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashant-gurung899 prashant-gurung899 force-pushed the update-link-share-project-space-file branch from 6322a41 to 5e7e1e3 Compare June 7, 2024 05:55
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit c733f3b into owncloud:master Jun 7, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jun 7, 2024
…oject-space-file

[tests-only][full-CI] adding test for updating share link of a resource in project space.
@prashant-gurung899 prashant-gurung899 deleted the update-link-share-project-space-file branch June 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants