Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only]changed sharing test #10531

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[test-only]changed sharing test #10531

merged 2 commits into from
Mar 5, 2024

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Mar 1, 2024

part of #10259

  • deleted acceptance tests related sharing actions
  • added missed e2e test for:
    • remove share with group
    • sharing using quick action
    • update share using custum permissions
  • copy/move test. expect 201 and 204 code responses
  • shared with others - check displaying resources with same name

Copy link

update-docs bot commented Mar 1, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Comment on lines +180 to +182
| resource | to | option |
| example1.txt | sub/folder1 | keep both |
| folder1/example1.txt | sub/folder1 | replace |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the issue fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, issue is relevant only for copying moving folder

for file works correct

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good. Also please, backport it to the stable-8

@ScharfViktor ScharfViktor merged commit d84e6e9 into master Mar 5, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the changeSharingTests branch March 5, 2024 09:44
ScharfViktor added a commit that referenced this pull request Mar 5, 2024
* changed sharing test

* update share
@ScharfViktor
Copy link
Contributor Author

Also please, backport it to the stable-8

#10543

phil-davis added a commit that referenced this pull request Mar 6, 2024
[test-only]changed sharing test (#10531)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants