perf: make routes lazy #11089
Draft
perf: make routes lazy #11089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Makes all routes lazy so their components don't get loaded with the initial load, but when navigating to the routes.
|
I'm a bit torn here. It adds a bit of complexity while (currently) having near to no impact (Web now loads smaller but more chunks, even resulting in ~10-20ms more initial loading time - however this is not noticable). There might be situations in the future where this would be useful though, e.g. when some route component loads a lot of dependencies. |
JammingBen
force-pushed
the
perf/lazy-routes
branch
from
cb7bf70
to
22012d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes all routes lazy so their components don't get loaded with the initial load, but when navigating to the routes.
The
ComponentLoaderis basically a component wrapping the route components to display a loading spinner during the loading times.Related Issue
Types of changes