Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add save as #11586

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Add save as #11586

merged 10 commits into from
Sep 24, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 16, 2024 •
edited
Loading

Description

image

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Sep 16, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review September 19, 2024 12:13
JammingBen
JammingBen reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions in the regular embed mode are now missing their margins:

image

Other than that, it works perfectly as far as I can tell.

packages/web-pkg/src/components/AppTemplates/AppWrapper.vue Show resolved Hide resolved
kulmann
kulmann reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: on navigation the input field with the new file name gets reset all the time. If I change the name first and then navigate somewhere else, I need to type the new file name again. edit: hard to solve. We'll accept this as a known issue for now. The standard workflow is to find a suitable location and after that choose a new file name anyway.

kulmann
kulmann reviewed Sep 20, 2024
View reviewed changes
docs/embed-mode/_index.md Outdated Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor Author

As discussed: The new saved file will now be opened, we don't change anything yet on our autosave implementation

JammingBen
JammingBen approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few optional suggestions left from my side, approving anyways 👍

packages/web-pkg/src/components/Modals/SaveAsModal.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/components/Modals/SaveAsModal.vue Outdated Show resolved Hide resolved
@AlexAndBear @kulmann
Open in new tab
e310c6b 
Co-authored-by: Benedikt Kulmann <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit fbad5cd into master Sep 24, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the save-as branch September 24, 2024 06:43
ownclouders pushed a commit that referenced this pull request Sep 24, 2024
@AlexAndBear @kulmann
Add save as (#11586)
83c0007 
* Add save as

* Disable trash in embed mode

* Fix bug where hide-logo query is not persistent

* Fix: snackbar overlying embed actions

Co-authored-by: Benedikt Kulmann <[email protected]>

---------

Co-authored-by: Benedikt Kulmann <[email protected]>
@micbar micbar mentioned this pull request Oct 1, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Save as" to App Top Bar (without rename)
4 participants
@AlexAndBear @kulmann @pascalwengerter @JammingBen