fix: right sidebar focus #11609
Merged
fix: right sidebar focus #11609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 2 main issues with the right sidebar focus: * Prevents the sidebar from stealing the focus when loading the page with the sidebar being initially opened. * Sets the focus on the sidebar when necessary (e.g. when opening/closing a specific sidebar panel).
JammingBen
force-pushed
the
fix/sidebar-focus
branch
from
cb2dc5b
to
11adc8b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 2 main issues with the right sidebar focus:
I decided to get rid of the visibility- and the hidden-observer because it's painful to tweak them right and they weren't working as supposed anyway. The simple solution I went for sets the focus when opening the sidebar or a specific panel, or when closing a sub-panel and returning to the root panel.
Related Issue
Types of changes