Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Skip private link related tests on ocis #8076

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

SwikritiT
Copy link
Contributor

Description

This PR skips the tests related to private-links

Related Issue

Motivation and Context

If I understand issue #6844 correctly then there won't be a separate copy-private-link button in ocis which is the case for oc10 right now. In the case of ocis

As a user I want to get a link to a resource as easily and quickly as possible. I don't want to decide whether I need a 'private' or a 'public' link in the first place. Still, I might want to decide (e.g., for security reasons) for whom the link is usable (link scope): for everybody (public) / only invited people (private).

So Private link tests might be obsolete in this case, thus they are skipped but in oc10 there is a copy-private-link button

How Has This Been Tested?

  • CI
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Dec 7, 2022
@SwikritiT
Copy link
Contributor Author

If I understand issue #6844 correctly then there won't be a separate copy-private-link button in ocis which is the case for oc10 right now. In the case of ocis

As a user I want to get a link to a resource as easily and quickly as possible. I don't want to decide whether I need a 'private' or a 'public' link in the first place. Still, I might want to decide (e.g., for security reasons) for whom the link is usable (link scope): for everybody (public) / only invited people (private).

So Private link tests might be obsolete in this case, thus they are skipped but in oc10 there is a copy-private-link button

cc: @ScharfViktor @kulmann @phil-davis @individual-it

@SwikritiT SwikritiT marked this pull request as ready for review December 7, 2022 08:14
@ownclouders
Copy link
Contributor

Results for oCISFiles5 https://drone.owncloud.com/owncloud/web/30478/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesCopy-copyPrivateLinks_feature-L20.png

webUIFilesCopy-copyPrivateLinks_feature-L20.png

webUIFilesCopy-copyPrivateLinks_feature-L21.png

webUIFilesCopy-copyPrivateLinks_feature-L21.png

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor
Copy link
Contributor

I agree with skiping test. ocis behavior is different and these tests don't work. we shouldn't run them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants