Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Refactor test steps #8093

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 9, 2022

Description

In the changed feature file the user was logged in before API requests are sent to the server to perform some of the operations and page reload was necessary in some cases to fetch the changes made by the API requests. I think it's better if the user is logged in after the API requests are sent. This PR refactors the steps so that the user is logged in after the API request is sent.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Dec 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grgprarup grgprarup merged commit ea9ac22 into master Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-expected-to-fail-for-closed-issue-part-5 branch December 13, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants