Replaced circle markers with modified canvas markers from @simerca/vu… #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to start off by saying I'm grateful for the project, it allowed me to move away from google and have more control over my data.
This modification is due to quite slow rendering of point markers on the map for larger datasets. I imported my data from google, which contains around 1.3 mil locations and I hoped I would be able to see at least portions of them, but with current way of rendering them (as separate DOM elements).
Performance
Currently loading a month of data (~7000 points) with current approach I'm barely able to move around, getting a frame every few seconds.
With the canvas approach for the same amount of data, moving is very fluid and responsive except minor stutters which I think can be fixed (loading points during movement)
Now I'm actually able to load over 200k points and it's still (mostly) usable so I think it's a great improvement and I don't see a reason as to why not implement it.
Now I also want to say that this branch is very WIP, but I literally never touched Vue before that attempt so I'm still not sure how, but I know that there's ways of doing this properly (unlike I did).
I used Vue component from simerca, and I just pasted it into the project (I'm sure there's a way better way to import it), but I also modified it a bit so this might pose a problem.
Things still left to do:
I don't expect this branch to get merged but I hope for some tips on what I have to do to get this in a state which could be merged. Thanks in advance :)