Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stdin and stdout 1 challenge solution. #123

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

oskarikotajarvi
Copy link
Contributor

Closing Issue/Referencing Issue

issue reference (#1)

Changes Made In Pull Request

@welcome
Copy link

welcome bot commented Oct 23, 2018

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉
I'll take a look at it ASAP!

@ows-ali
Copy link
Owner

ows-ali commented Oct 23, 2018

@oskarikotajarvi

  • Please remove .project file or add an issue first
  • Please add your name/info in README.md and push again

@oskarikotajarvi
Copy link
Contributor Author

@ows-ali
I'm quite new to this. How should i go about to remove the .project file from the PR?

@oskarikotajarvi
Copy link
Contributor Author

@ows-ali .project file has now been remover from the PR

@ows-ali
Copy link
Owner

ows-ali commented Oct 23, 2018

@oskarikotajarvi Awesome job!

@ows-ali ows-ali merged commit b9d9f93 into ows-ali:master Oct 23, 2018
@welcome
Copy link

welcome bot commented Oct 23, 2018

Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up!
alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants