Add custom template option #41
Conversation
| help='Add the data that you want to send along with the header.') | ||
| parser.add_argument( | ||
| '--template', '-t', | ||
| help='Add the path of the custom template you want to provide.') |
There was a problem hiding this comment.
You should add proper name for the custom template option ;)
|
@dhruvagarwal I am not really fan of this idea for 2 reasons:
What do you think? @arunk-s any thoughts on that? |
|
@DePierre I think your idea of writing the templates under a global directory sounds awesome, it will help us further in discovering the ways the users are using our tool, may be discover some bugs in our templates/code may be. |
|
@dhruvagarwal Do you think that you could add unittests for that new feature as well as the source code? That will be very helpful before merging the changes :) |
| help='Add the data that you want to send along with the header.') | ||
| parser.add_argument( | ||
| '--custom-template', '-t', | ||
| help='Add the path of the custom template you want to provide.') |
There was a problem hiding this comment.
Avoid 'you'. Keep it broad like "Specify path for custom templates."
|
@dhruvagarwal Reading the modification, what happens if the user specifies a custom template |
|
@dhruvagarwal Do you need more information in order to update your PR regarding the custom template idea? |
This is a POC for adding a custom template. Currently this is intended to work when no language option is provided .