Skip to content

Commit

Permalink
feat(oxc): remove oxc_napi crate (#7634)
Browse files Browse the repository at this point in the history
napi has a limitation, it cannot feature gate type exposure.

closes #7623
  • Loading branch information
Boshen authored Dec 4, 2024
1 parent e824501 commit 771c698
Show file tree
Hide file tree
Showing 22 changed files with 724 additions and 779 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,12 @@ jobs:
- uses: Boshen/setup-rust@main
if: steps.filter.outputs.src == 'true'
with:
save-cache: ${{ github.ref_name == 'main' }}
cache-key: warm
- uses: ./.github/actions/pnpm
if: steps.filter.outputs.src == 'true'
- run: pnpm run build
- run: pnpm run build-dev
if: steps.filter.outputs.src == 'true'
- run: pnpm run test
if: steps.filter.outputs.src == 'true'
- run: git diff --exit-code # Must commit everything
if: steps.filter.outputs.src == 'true'
45 changes: 15 additions & 30 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ oxc_estree = { version = "0.38.0", path = "crates/oxc_estree" }
oxc_isolated_declarations = { version = "0.38.0", path = "crates/oxc_isolated_declarations" }
oxc_mangler = { version = "0.38.0", path = "crates/oxc_mangler" }
oxc_minifier = { version = "0.38.0", path = "crates/oxc_minifier" }
oxc_napi = { version = "0.38.0", path = "crates/oxc_napi" }
oxc_parser = { version = "0.38.0", path = "crates/oxc_parser" }
oxc_regular_expression = { version = "0.38.0", path = "crates/oxc_regular_expression" }
oxc_semantic = { version = "0.38.0", path = "crates/oxc_semantic" }
Expand All @@ -109,9 +108,9 @@ oxc_tasks_common = { path = "tasks/common" }
oxc_tasks_transform_checker = { path = "tasks/transform_checker" }

# Relaxed version so the user can decide which version to use.
napi = "3.0.0-alpha"
napi = "3.0.0-alpha.11"
napi-build = "2.1.3"
napi-derive = "3.0.0-alpha"
napi-derive = "3.0.0-alpha.11"

# Relaxed version so the user can decide which version to use.
proc-macro2 = "1"
Expand Down
2 changes: 0 additions & 2 deletions crates/oxc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ oxc_span = { workspace = true }
oxc_syntax = { workspace = true }
oxc_transformer = { workspace = true, optional = true }

napi = { workspace = true, optional = true, features = ["async"] }

[features]
full = [
"codegen",
Expand Down
33 changes: 0 additions & 33 deletions crates/oxc_napi/Cargo.toml

This file was deleted.

30 changes: 0 additions & 30 deletions crates/oxc_napi/src/isolated_declarations.rs

This file was deleted.

5 changes: 0 additions & 5 deletions crates/oxc_napi/src/lib.rs

This file was deleted.

Loading

0 comments on commit 771c698

Please sign in to comment.