feat(oxc): remove oxc_napi crate

napi has a limitation, it cannot feature gate type exposure.
oxc-project · Dec 4, 2024 · e75c19a · e75c19a
1 parent 543df6e
commit e75c19a
Show file tree

Hide file tree

Showing 23 changed files with 724 additions and 790 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -285,11 +285,12 @@ jobs:
       - uses: Boshen/setup-rust@main
         if: steps.filter.outputs.src == 'true'
         with:
-          save-cache: ${{ github.ref_name == 'main' }}
           cache-key: warm
       - uses: ./.github/actions/pnpm
         if: steps.filter.outputs.src == 'true'
-      - run: pnpm run build
+      - run: pnpm run build-dev
         if: steps.filter.outputs.src == 'true'
       - run: pnpm run test
         if: steps.filter.outputs.src == 'true'
+      - run: git diff --exit-code # Must commit everything
+        if: steps.filter.outputs.src == 'true'
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -91,7 +91,6 @@ oxc_estree = { version = "0.38.0", path = "crates/oxc_estree" }
 oxc_isolated_declarations = { version = "0.38.0", path = "crates/oxc_isolated_declarations" }
 oxc_mangler = { version = "0.38.0", path = "crates/oxc_mangler" }
 oxc_minifier = { version = "0.38.0", path = "crates/oxc_minifier" }
-oxc_napi = { version = "0.38.0", path = "crates/oxc_napi" }
 oxc_parser = { version = "0.38.0", path = "crates/oxc_parser" }
 oxc_regular_expression = { version = "0.38.0", path = "crates/oxc_regular_expression" }
 oxc_semantic = { version = "0.38.0", path = "crates/oxc_semantic" }
@@ -109,9 +108,9 @@ oxc_tasks_common = { path = "tasks/common" }
 oxc_tasks_transform_checker = { path = "tasks/transform_checker" }
 
 # Relaxed version so the user can decide which version to use.
-napi = "3.0.0-alpha"
+napi = "3.0.0-alpha.11"
 napi-build = "2.1.3"
-napi-derive = "3.0.0-alpha"
+napi-derive = "3.0.0-alpha.11"
 
 # Relaxed version so the user can decide which version to use.
 proc-macro2 = "1"

diff --git a/crates/oxc/Cargo.toml b/crates/oxc/Cargo.toml
@@ -42,8 +42,6 @@ oxc_span = { workspace = true }
 oxc_syntax = { workspace = true }
 oxc_transformer = { workspace = true, optional = true }
 
-napi = { workspace = true, optional = true, features = ["async"] }
-
 [features]
 full = [
   "codegen",

diff --git a/crates/oxc_napi/Cargo.toml b/crates/oxc_napi/Cargo.toml
diff --git a/crates/oxc_napi/src/isolated_declarations.rs b/crates/oxc_napi/src/isolated_declarations.rs
diff --git a/crates/oxc_napi/src/lib.rs b/crates/oxc_napi/src/lib.rs