fix(ast): few serialization issues #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2522 will not alter performanceComparing Summary
|
Boshen
changed the title
Boshen
changed the title
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
A few more I missed in oxc-project#2506. Re oxc-project#2463. Only remaining snake_case in the current types of the AST: `trailing_comma` in ArrayExpression, ObjectExpression & ArrayAssignmentTarget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more I missed in #2506. Re #2463.
Only remaining snake_case in the current types of the AST:
trailing_commain ArrayExpression, ObjectExpression & ArrayAssignmentTarget. I waiting for the discussion on #2521 to choose between skip and camelCase.