-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): @typescript-eslint/prefer-literal-enum-member #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3134 will not alter performanceComparing Summary
|
mysteryven
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice rule, thank you!
mysteryven
changed the title
feat(linter): implement @typescript-eslint/prefer-literal-enum-member
feat(linter): @typescript-eslint/prefer-literal-enum-member
May 1, 2024
Brooooooklyn
referenced
this pull request
in toeverything/AFFiNE
May 7, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.1` -> `0.3.2`](https://renovatebot.com/diffs/npm/oxlint/0.3.1/0.3.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.3.1/0.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oxc-project/oxc (oxlint)</summary> ### [`v0.3.2`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.2): oxlint v0.3.2 [Compare Source](https://togithub.com/oxc-project/oxc/compare/99d46f9e489663935780f434f52711787ff1de19...a7940868c6e66d16814ebef5c8dbbfd9b948a0cd) #### What's Changed [Oxlint Import Plugin Alpha Release](http://localhost:5173/blog/2024-05-04-import-plugin-alpha.html) - feat(linter): [@​typescript-eslint/prefer-literal-enum-member](https://togithub.com/typescript-eslint/prefer-literal-enum-member) by [@​kaykdm](https://togithub.com/kaykdm) in [https://github.com/oxc-project/oxc/pull/3134](https://togithub.com/oxc-project/oxc/pull/3134) - feat(linter): add more "ban-ts-comment" test cases. by [@​woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3107](https://togithub.com/oxc-project/oxc/pull/3107) - feat(linter): eslint-plugin-jest/require-hook by [@​eryue0220](https://togithub.com/eryue0220) in [https://github.com/oxc-project/oxc/pull/3110](https://togithub.com/oxc-project/oxc/pull/3110) - feat(linter): eslint/no-await-in-loop by [@​woai3c](https://togithub.com/woai3c) in [https://github.com/oxc-project/oxc/pull/3070](https://togithub.com/oxc-project/oxc/pull/3070) - feat(linter): typescript-eslint/prefer-enum-initializers by [@​todor-a](https://togithub.com/todor-a) in [https://github.com/oxc-project/oxc/pull/3097](https://togithub.com/oxc-project/oxc/pull/3097) - feat(linter/jsdoc): Implement `implements-on-classes` rule by [@​leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3081](https://togithub.com/oxc-project/oxc/pull/3081) - feat(linter/jsdoc): Implement check-tag-names rule by [@​leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3029](https://togithub.com/oxc-project/oxc/pull/3029) - feat(linter/jsdoc): Implement no-defaults rule by [@​leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3098](https://togithub.com/oxc-project/oxc/pull/3098) - feat(linter/jsdoc): Implement require-yields rule by [@​leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3150](https://togithub.com/oxc-project/oxc/pull/3150) - feat(linter/jsdoc): Support settings.ignore(Private|Internal) by [@​leaysgur](https://togithub.com/leaysgur) in [https://github.com/oxc-project/oxc/pull/3147](https://togithub.com/oxc-project/oxc/pull/3147) #### New Contributors - [@​vsn4ik](https://togithub.com/vsn4ik) made their first contribution in [https://github.com/oxc-project/oxc/pull/3118](https://togithub.com/oxc-project/oxc/pull/3118) **Full Changelog**: oxc-project/oxc@oxlint_v0.3.1...oxlint_v0.3.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2180
original implementation