feat(linter): implement @typescript-eslint/prefer-namespace-keyword #3881
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3881 will not alter performanceComparing Summary
|
| fn prefer_namespace_keyword_diagnostic(span0: Span) -> OxcDiagnostic { | ||
| OxcDiagnostic::warn("typescript-eslint(prefer-namespace-keyword): Use 'namespace' instead of 'module' to declare custom TypeScript modules.") | ||
| .with_help("'Require using `namespace` keyword over `module` keyword to declare custom TypeScript modules") | ||
| .with_labels([span0.into()]) |
There was a problem hiding this comment.
prefer with_label when only labelling a single span
|
|
||
| ctx.diagnostic_with_fix(prefer_namespace_keyword_diagnostic(decl.span), |fixer| { | ||
| // replace `module` with `namespace` | ||
| fixer.replace(Span::new(id.span.start - 7, id.span.start - 1), "namespace") |
There was a problem hiding this comment.
This looks like it will break if there is more than once space between module and the identifier. Is there no span for the module keyword?
|
Extending "plugin:@typescript-eslint/stylistic" in an ESLint configuration enables this rule. This appears to be a stylistic rule, which we don't accept. Let me make a note of this so we don't accept more stylistic rules. |
Related issue: #2180
original implementation