Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi/parser): add get_line_column_number API #7765

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 10, 2024

No description provided.

Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the title feat(napi/parer): add get_line_column_number API feat(napi/parer): add get_line_column API Dec 10, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 10, 2024
@Boshen Boshen changed the base branch from 12-10-feat_data_structures_add_rope to graphite-base/7765 December 10, 2024 10:30
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #7765 will not alter performance

Comparing 12-10-feat_napi_parer_add_get_line_column_number_api (f3cfa7f) with main (016ae92)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 12-10-feat_napi_parer_add_get_line_column_number_api branch from bd36325 to cbb98c9 Compare December 10, 2024 10:34
@Boshen Boshen force-pushed the graphite-base/7765 branch from 52a4180 to cf2ee06 Compare December 10, 2024 10:34
@Boshen Boshen changed the base branch from graphite-base/7765 to main December 10, 2024 10:35
@Boshen Boshen force-pushed the 12-10-feat_napi_parer_add_get_line_column_number_api branch from cbb98c9 to 958911d Compare December 10, 2024 10:35
@overlookmotel overlookmotel changed the title feat(napi/parer): add get_line_column API feat(napi/parser): add get_line_column API Dec 10, 2024
@Boshen Boshen force-pushed the 12-10-feat_napi_parer_add_get_line_column_number_api branch from 958911d to 5708b1c Compare December 10, 2024 12:41
@Boshen Boshen changed the title feat(napi/parser): add get_line_column API feat(napi/parser): add get_line_column_number API Dec 10, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@Boshen Boshen force-pushed the 12-10-feat_napi_parer_add_get_line_column_number_api branch from 5708b1c to f3cfa7f Compare December 10, 2024 12:49
Copy link

graphite-app bot commented Dec 10, 2024

Merge activity

@graphite-app graphite-app bot merged commit f3cfa7f into main Dec 10, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 12-10-feat_napi_parer_add_get_line_column_number_api branch December 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant