feat(transformer/class-properties): transform super member expressions that are inside static prop initializer #7815

Dunqing · 2024-12-12T09:27:54Z

This PR support for transforming super.prop to babelHelpers.superPropGet(_B, "prop", _B)

Input:

class A {
  static prop = 1;
}

class B extends A {
  static prop = 2;
  static propA = super.prop;
  static getPropA = () => super.prop;
}

Output:

var _B;
class A {}
babelHelpers.defineProperty(A, "prop", 1);
class B extends A {}
_B = B;
babelHelpers.defineProperty(B, "prop", 2);
babelHelpers.defineProperty(B, "propA", babelHelpers.superPropGet(_B, "prop", _B));
babelHelpers.defineProperty(B, "getPropA", () => babelHelpers.superPropGet(_B, "prop", _B));

Dunqing · 2024-12-12T09:28:14Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-12-12T09:41:03Z

CodSpeed Performance Report

Merging #7815 will not alter performance

_{Comparing 12-12-feat_transformer_class-properties_transform_super_member_expression_that_is_inside_static_prop_initializer (e727ae9) with main (b290ebd)}

Summary

✅ 29 untouched benchmarks

crates/oxc_transformer/src/es2022/class_properties/supers.rs

Dunqing · 2024-12-12T14:29:01Z

Thank @overlookmotel for reviewing, now it more clearer!

overlookmotel

Pushed 4 nitty commits. @Dunqing If you're OK with them, please merge.

graphite-app · 2024-12-13T02:33:16Z

Merge activity

Dec 12, 9:33 PM EST: A user added this pull request to the Graphite merge queue.
Dec 12, 9:38 PM EST: A user merged this pull request with the Graphite merge queue.

…s that are inside static prop initializer (#7815) This PR support for transforming `super.prop` to `babelHelpers.superPropGet(_B, "prop", _B)` Input: ```js class A { static prop = 1; } class B extends A { static prop = 2; static propA = super.prop; static getPropA = () => super.prop; } ``` Output: ```js var _B; class A {} babelHelpers.defineProperty(A, "prop", 1); class B extends A {} _B = B; babelHelpers.defineProperty(B, "prop", 2); babelHelpers.defineProperty(B, "propA", babelHelpers.superPropGet(_B, "prop", _B)); babelHelpers.defineProperty(B, "getPropA", () => babelHelpers.superPropGet(_B, "prop", _B)); ```

…ral` (#7825) Follow-on after #7815. Generated `StringLiteral`s should have `raw: None`.

## [0.41.0] - 2024-12-13 - fb325dc ast: [**BREAKING**] `span` field must be the first element (#7821) (Boshen) - 96a26d3 ast: [**BREAKING**] Rename `is_strict` methods to `has_use_strict_directive` (#7783) (overlookmotel) ### Features - 8991f33 ast: Add `visit_span` to `Visit` and `VisitMut` (#7816) (overlookmotel) - f7900ab ast: Add `ArrowFunctionExpression::has_use_strict_directive` method (#7784) (overlookmotel) - e727ae9 transformer/class-properties: Transform super member expressions that are inside static prop initializer (#7815) (Dunqing) ### Bug Fixes - 7610dc1 parser: Parse `import source from 'mod'` (#7833) (Boshen) - 9479e2b semantic: Missing references when `export {}` references a type-only binding and a normal (#7812) (Yunfei He) - 7a83230 semantic: Missing reference when `export default` references a type alias binding (#7813) (Dunqing) - 4a3bca8 semantic: Fix identifying strict mode arrow functions (#7785) (overlookmotel) - 5b7e1ad transformer: Remove span of define value (#7811) (Hiroshi Ogawa) - 14896cb transformer/class-properties: Create temp vars in correct scope (#7824) (overlookmotel) - 25bb6da transformer/class-properties: Fix `ScopeId`s in instance prop initializers (#7823) (overlookmotel) - 65b109a transformer/class-properties: No `raw` for generated `StringLiteral` (#7825) (overlookmotel) - 2964a61 transformer/class-properties: Unwrap failed when private field expression doesn't contain optional expression in `ChainExpression` (#7798) (Dunqing) - 6fa6785 transformer/class-properties: Panic when the callee or member is `ParenthesisExpression` or TS-syntax expressions. (#7795) (Dunqing) - bb22c67 transformer/class-properties: Fix `ScopeId`s in static prop initializers (#7791) (overlookmotel) - caa57f1 transformer/class-properties: Fix scope flags in static prop initializers (#7786) (overlookmotel) ### Performance - 4448b63 codegen: Faster writing indentation (#7820) (overlookmotel) - afaaffa codegen: Fast path for `options.print_comments()` (#7806) (Boshen) ### Refactor - 0f367e5 semantic: Improve the logic of resolving references to be cleaner (#7829) (Dunqing) - 5710950 semantic: Move export-related reference flags logic to visit functions (#7828) (Dunqing) - b290ebd transformer: Handle `<CWD>` in test runner (#7799) (Dunqing) - e70deb9 transformer/class-properties: Locate instance props insertion location in separate step (#7819) (overlookmotel) - afc5f1e transformer/class-properties: De-deduplicate code (#7805) (overlookmotel) - 47a91d2 transformer/class-properties: Shorten code (#7804) (overlookmotel) - 54ef2b9 transformer/class-properties: Rename `debug_assert_expr_is_not_parenthesis_or_typescript_syntax` (#7803) (overlookmotel) - 3cdc47c transformer/class-properties: `#[inline(always)]` on `assert_expr_neither_parenthesis_nor_typescript_syntax` (#7802) (overlookmotel) ### Testing - d72c888 transformer/replace-global-defines: Remove panicking test (#7838) (overlookmotel) Co-authored-by: Boshen <[email protected]>

Dunqing requested a review from overlookmotel as a code owner December 12, 2024 09:27

github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 12, 2024

github-actions bot added the C-enhancement Category - New feature or request label Dec 12, 2024

Dunqing force-pushed the 12-12-feat_transformer_class-properties_transform_super_member_expression_that_is_inside_static_prop_initializer branch 3 times, most recently from db00404 to 018bc2a Compare December 12, 2024 09:33

overlookmotel requested changes Dec 12, 2024

View reviewed changes

crates/oxc_transformer/src/es2022/class_properties/supers.rs Outdated Show resolved Hide resolved

crates/oxc_transformer/src/es2022/class_properties/supers.rs Outdated Show resolved Hide resolved

overlookmotel requested changes Dec 12, 2024

View reviewed changes

crates/oxc_transformer/src/es2022/class_properties/supers.rs Outdated Show resolved Hide resolved

Dunqing requested a review from overlookmotel December 12, 2024 14:29

overlookmotel approved these changes Dec 12, 2024

View reviewed changes

overlookmotel mentioned this pull request Dec 13, 2024

fix(transformer/class-properties): no raw for generated StringLiteral #7825

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 13, 2024

Dunqing force-pushed the 12-12-feat_transformer_class-properties_transform_super_member_expression_that_is_inside_static_prop_initializer branch from fcdd421 to e727ae9 Compare December 13, 2024 02:33

Dunqing pushed a commit that referenced this pull request Dec 13, 2024

fix(transformer/class-properties): no raw for generated `StringLite…

65b109a

…ral` (#7825) Follow-on after #7815. Generated `StringLiteral`s should have `raw: None`.

graphite-app bot merged commit e727ae9 into main Dec 13, 2024
26 checks passed

graphite-app bot deleted the 12-12-feat_transformer_class-properties_transform_super_member_expression_that_is_inside_static_prop_initializer branch December 13, 2024 02:38

oxc-bot mentioned this pull request Dec 13, 2024

release(crates): v0.41.0 #7846

Merged

overlookmotel mentioned this pull request Dec 14, 2024

Remaining problems for class properties transform #7730

Open

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(transformer/class-properties): transform super member expressions that are inside static prop initializer #7815

feat(transformer/class-properties): transform super member expressions that are inside static prop initializer #7815

Dunqing commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024 •

edited by overlookmotel

Loading

codspeed-hq bot commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024

overlookmotel left a comment •

edited

Loading

graphite-app bot commented Dec 13, 2024 •

edited

Loading

feat(transformer/class-properties): transform super member expressions that are inside static prop initializer #7815

feat(transformer/class-properties): transform super member expressions that are inside static prop initializer #7815

Conversation

Dunqing commented Dec 12, 2024 • edited Loading

Dunqing commented Dec 12, 2024 • edited by overlookmotel Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Dec 12, 2024 • edited Loading

CodSpeed Performance Report

Merging #7815 will not alter performance

Summary

Dunqing commented Dec 12, 2024

overlookmotel left a comment • edited Loading

Choose a reason for hiding this comment

graphite-app bot commented Dec 13, 2024 • edited Loading

Merge activity

Dunqing commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024 •

edited by overlookmotel

Loading

codspeed-hq bot commented Dec 12, 2024 •

edited

Loading

overlookmotel left a comment •

edited

Loading

graphite-app bot commented Dec 13, 2024 •

edited

Loading