-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): rule no-restricted-imports
support missing options
#8076
base: main
Are you sure you want to change the base?
fix(linter): rule no-restricted-imports
support missing options
#8076
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8076 will not alter performanceComparing Summary
|
… option inside `patterns`
no-restricted-imports
support regex
option inside patterns
no-restricted-imports
support regex
& importNamePattern
option inside patterns
no-restricted-imports
support regex
& importNamePattern
option inside patterns
no-restricted-imports
support missing options
…ld regex in `from_configuration`
/ping #8113 is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Let's use is_match
instead of find().is_some()
, but otherwise this looks good!
@Boshen only your approval is missing :) |
https://eslint.org/docs/latest/rules/no-restricted-imports#regex
https://eslint.org/docs/latest/rules/no-restricted-imports#importnamepattern
https://eslint.org/docs/latest/rules/no-restricted-imports#allowimportnamepattern
Needed to install
regress
to support JS Sntax like Lookaheads and LookbehindsNext Goals: