Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): report syntax errors for missing constructor implementations #8081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 23, 2024

No description provided.

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Dec 23, 2024
Copy link
Contributor Author

camc314 commented Dec 23, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 23, 2024 20:05
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #8081 will not alter performance

Comparing c/12-23-fix_parser_report_syntax_errors_for_missing_constructor_implementations (b9ac5c4) with main (618b6aa)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 force-pushed the c/12-23-fix_parser_report_syntax_errors_for_missing_constructor_implementations branch from 6d46700 to 3bb0569 Compare December 23, 2024 20:44
@camc314 camc314 force-pushed the c/12-23-fix_parser_report_syntax_errors_for_missing_constructor_implementations branch from 3bb0569 to b9ac5c4 Compare December 23, 2024 21:43
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 24, 2024
Copy link
Member

Boshen commented Dec 24, 2024

Merge activity

  • Dec 23, 8:35 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 24, 1:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 24, 4:23 AM UTC: A user added this pull request to the Graphite merge queue.
  • Dec 24, 4:24 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.

@camc314
Copy link
Contributor Author

camc314 commented Dec 24, 2024

will rebase these in the morning

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants