Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minifier): clean up peephole_substitute_alternate_syntax.rs #8111

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 25, 2024

No description provided.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 25, 2024
Copy link
Member Author

Boshen commented Dec 25, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Dec 25, 2024

Merge activity

@Boshen Boshen force-pushed the 12-25-refactor_minifier_clean_up_peephole_substitute_alternate_syntax.rs_ branch from 2595e7d to e594c39 Compare December 25, 2024 13:54
@graphite-app graphite-app bot merged commit e594c39 into main Dec 25, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 12-25-refactor_minifier_clean_up_peephole_substitute_alternate_syntax.rs_ branch December 25, 2024 13:59
Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #8111 will improve performances by 3.5%

Comparing 12-25-refactor_minifier_clean_up_peephole_substitute_alternate_syntax.rs_ (e594c39) with main (5a1311e)

Summary

⚡ 2 improvements
✅ 27 untouched benchmarks

Benchmarks breakdown

Benchmark main 12-25-refactor_minifier_clean_up_peephole_substitute_alternate_syntax.rs_ Change
minifier[react.development.js] 1.9 ms 1.8 ms +3.5%
minifier[typescript.js] 345.8 ms 335.2 ms +3.16%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant