Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix psd scaling checks #158

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix psd scaling checks #158

merged 1 commit into from
Mar 1, 2024

Conversation

goulart-paul
Copy link
Member

Fixes a panic / crash condition in PSD scaling step

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@f8a1f1a). Click here to learn what that means.

Files Patch % Lines
src/cones/coneops_psdtrianglecone.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #158   +/-   ##
==========================================
  Coverage           ?   82.75%           
==========================================
  Files              ?       44           
  Lines              ?     3293           
  Branches           ?        0           
==========================================
  Hits               ?     2725           
  Misses             ?      568           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goulart-paul goulart-paul merged commit 57a6f8c into develop Mar 1, 2024
4 checks passed
@goulart-paul goulart-paul deleted the pg/fix_cholesky_error branch May 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant