Skip to content

Commit

Permalink
Don't call pool_connection_authorized here! (#6579)
Browse files Browse the repository at this point in the history
Don't use `pool_connection_authorized` from within `transaction_async`'s
function, use the `conn` that is supplied for this purpose.

I don't know how bad this is (will CRDB just nest things?) but it
strikes me as wrong, so here's the PR!
  • Loading branch information
jmpesp authored Sep 14, 2024
1 parent 09c93ee commit 6c3fc3f
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -894,9 +894,7 @@ impl DataStore {
.check_if_exists::<RegionSnapshotReplacementStep>(
region_snapshot_replacement_step_id,
)
.execute_and_check(
&*self.pool_connection_authorized(opctx).await?,
)
.execute_and_check(&conn)
.await?;

match result.status {
Expand Down

0 comments on commit 6c3fc3f

Please sign in to comment.