[reconfigurator] Enable clickhouse services via clickhouse-admin #6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karencfv
commented
Oct 3, 2024
karencfv
changed the title
|
@andrewjstone, please feel free to directly modify, merge, or close this PR directly, as I'll be out for two weeks :) |
andrewjstone
approved these changes
Oct 9, 2024
| rqctx: RequestContext<Self::Context>, | ||
| body: TypedBody<KeeperConfigurableSettings>, | ||
| ) -> Result<HttpResponseCreated<KeeperConfig>, HttpError> { | ||
| let ctx = rqctx.context(); | ||
| let keeper = body.into_inner(); | ||
| // TODO(https://github.com/oxidecomputer/omicron/issues/5999): Do something |
There was a problem hiding this comment.
We still want to use the generation number to prevent unnecessary config generations on every push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit makes a few changes to the way the
clickhouse_serverandclickhouse_keeperSMF services are launched:Related: #5999