Add tfport-data-link timeseries schema and SMF config adds. #6918
+269
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
b1c33da
to
6a92864
Compare
zeeshanlakhani
commented
Oct 29, 2024
| @@ -0,0 +1,132 @@ | |||
| format_version = 1 | |||
There was a problem hiding this comment.
@bnaecker this is a different timeseries (from sled-data-link) due to the switch information fields.
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
3 times, most recently
from
4c9a71d
to
819eded
Compare
Nieuwejaar
reviewed
Nov 1, 2024
This shows the diff against #6793. It'd be good to get that one in first and I'll switch this PR against |
|
So, yeah, @Nieuwejaar, it'd be good to get #6793 in first, and then this, but definitely want your take on the pkt_source updates here. |
|
Update: I'll make these changes on this PR:
|
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
from
ab1f377
to
8f01c33
Compare
|
Will push conflict fixes, etc, once things are up to date (doesn't impact review) |
|
Rust issues stuck behind: #6914. |
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
7b361fa
to
01f2a0b
Compare
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
4 times, most recently
from
50648d2
to
05c181e
Compare
Related to oxidecomputer/dendrite#1033. New timeseries (from sled-data-link) as we've added switch information in the metadata.
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
01f2a0b
to
59a6171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to https://github.com/oxidecomputer/dendrite/pull/1033.
New timeseries (from
sled-data-link) as we've added switch informationin the metadata.
Related:
mainonce thezl/smf-sled-identsbranch is merged.package-manifestcommits to frommainonce https://github.com/oxidecomputer/dendrite/pull/1033 is merged.