Extract optional_time_delta for sharing
#7329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Yup, this looks good to me! I have a nearly-identical commit in my in-progress webhook branch, so you're enot the only person who wanted it!
david-crespo
force-pushed
the
crespo/extract-optional-time-delta
branch
from
c0ad1e0 to
0506cbb
Compare
|
After chatting, I don't think I actually I need this, so I'm going to close it and let you handle it in your PR. If that changes, I can always reoopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this on another model. Only change is making
deserializeandserializepubinstead ofpub(super).Update: I don't actually want it on a model, I want it on a view, which means it needs to be extracted all the way to
omicron-common.