Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up NVMe PRP parsing and add tests #468

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Clean up NVMe PRP parsing and add tests #468

merged 1 commit into from
Aug 1, 2023

Conversation

pfmooney
Copy link
Collaborator

After scrutinizing the PRP-related logic in our NVMe emulation, I felt like adding some unit tests.

luqmana
luqmana approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up and all the tests! 😍

lib/propolis/src/hw/nvme/cmds.rs
Comment on lines +684 to +685
self.next = PrpNext::List(entry, 0);
return self.get_next();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@pfmooney pfmooney merged commit 8266e61 into oxidecomputer:master Aug 1, 2023
8 checks passed
@pfmooney pfmooney deleted the nvme-prptest branch August 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqmana luqmana luqmana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfmooney @luqmana