Allow 64-vCPU instances on Helios (stlouis) #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on oxidecomputer/stlouis#458 (CR: 276) |
gjcolombo
approved these changes
Jul 26, 2023
With VM_MAXCPU expanded from 32 to 64 on the stlouis build of Helios, so too can the limit used for the checks in the Propolis library when constructing instance VMM resources. Fixes oxidecomputer#474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With VM_MAXCPU expanded from 32 to 64 on the stlouis build of Helios, so too can the limit used for the checks in the Propolis library when constructing instance VMM resources.
Fixes #474