Update propolis with new Crucible Volume change #485
Conversation
New crucible, which has updated Volume structure with Logger field. New VolumeConstructionRequest format which has sub-structures for all the fields. This also adds support for the VCR replacement, which can be used to replace a downstairs as well as validate a VCR for migration.
| @@ -16,7 +16,9 @@ use std::net::SocketAddr; | |||
| use uuid::Uuid; | |||
|
|
|||
| // Re-export types that are of a public struct | |||
| pub use crucible_client_types::VolumeConstructionRequest; | |||
| pub use crucible_client_types::{ | |||
| VcrFile, VcrRegion, VcrUrl, VcrVolume, VolumeConstructionRequest, | |||
There was a problem hiding this comment.
I'm not 100% sure this was the correct place to export these, but it worked :)
There was a problem hiding this comment.
This change is no longer part of the PR
|
This adds some of the support required in #470 |
leftwo
changed the title
|
Bad news from chat:
Which means we have to think a bit more here about the best way forward. We do need the functionality to compare VCRs. |
leftwo
changed the title
|
This change has been mostly redacted. All we have here now is an update to the Volume structure to include a |
New crucible, which has updated Volume structure with Logger field. New VolumeConstructionRequest format which has sub-structures for all the fields.
This also adds support for using a new VCR for replacement
This enables downstairs replacement in a running Volume, and can also be used for migration to validate a VCR.