Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to hyper v1 #745

Merged
merged 16 commits into from
Sep 27, 2024
Merged

update to hyper v1 #745

merged 16 commits into from
Sep 27, 2024

Conversation

ahl
Copy link
Contributor

@ahl ahl commented Aug 21, 2024

No description provided.

@ahl ahl marked this pull request as ready for review September 26, 2024 18:01
@ahl
Copy link
Contributor Author

ahl commented Sep 26, 2024

@pfmooney I'm going to update this with the progenitor and dropshot dependencies that I'm working on landing, but I was hoping you could get eyes on this

Copy link
Collaborator

@pfmooney pfmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small style nit

@@ -14,10 +14,10 @@ use std::sync::Arc;
use std::time::Duration;

use crate::serial::history_buffer::{HistoryBuffer, SerialHistoryOffset};
use dropshot::WebsocketConnectionRaw;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the use here, when the later references are made to dropshot::WebsocketConnectionRaw, rather than the bare name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um... bad programming? I'll fix it

@ahl ahl changed the title WIP: update to hyper v1 update to hyper v1 Sep 27, 2024
@ahl ahl merged commit 4ba9c33 into master Sep 27, 2024
11 checks passed
@ahl ahl deleted the hyper-v1 branch September 27, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants