Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundtrip JSON serialization/deserialization #20

Merged
merged 22 commits into from
Sep 24, 2024
Merged

Conversation

sneakers-the-rat
Copy link
Collaborator

@sneakers-the-rat sneakers-the-rat commented Sep 21, 2024

fix: #17

(will write description after draft complete)

  • Separate the core_schema generation from the json schema generation
  • Allow all array interface proxy types to be dumped to json
  • control over serialization
    • round_trip to control including extra metadata?
    • use context to control whether we dump the whole array or just the proxy info

todo

  • testing: test instantiation from the roundtrip json dict
  • testing: test absolute paths
  • testing: test relative_to paths
  • testing: test mark interface

@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 11005171737

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 329 of 329 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 99.231%

Totals Coverage Status
Change from base Build 10693070848: 0.9%
Covered Lines: 1162
Relevant Lines: 1171

💛 - Coveralls

@sneakers-the-rat sneakers-the-rat marked this pull request as ready for review September 24, 2024 01:19
@sneakers-the-rat sneakers-the-rat merged commit bd5b937 into main Sep 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roundtrip JSON serialization/deserialization
2 participants