Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor/deep link #1380

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

[WIP] Refactor/deep link #1380

wants to merge 10 commits into from

Conversation

bigearsenal
Copy link
Collaborator

@bigearsenal bigearsenal commented Jun 15, 2023 •
edited
Loading

Description of the changes

  • New package Deeplinking in KeyAppKit.
  • New tested class URLParser that handles all kind of deep linking and convert to custom type Deeplinking.Route.
  • New Deeplinking.Router class that hold last value of route instead of GlobalAppState.

TODO

  • Return logic of debugLoginFromURL.
  • Handle opening link more precisely without any delays.

@bigearsenal bigearsenal changed the title Refactor/deep link [WIP] Refactor/deep link Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrGiLong TrGiLong Awaiting requested review from TrGiLong

@sidorov-panda sidorov-panda Awaiting requested review from sidorov-panda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bigearsenal