[PWN-9260] [WIP] Withdrawal #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisemyon
reviewed
Jul 20, 2023
| @@ -424,6 +424,68 @@ extension Resolver: ResolverRegistering { | |||
| } | |||
| .scope(.session) | |||
|
|
|||
| register { | |||
| StrigaBankTransferUserDataRepository( | |||
lisemyon
reviewed
Jul 20, 2023
lisemyon
reviewed
Jul 20, 2023
| title: viewModel.actionTitle.uppercaseFirst, | ||
| style: .primaryWhite, | ||
| expandable: true, | ||
| isEnabled: true, |
There was a problem hiding this comment.
it is by default, no? or you will update it later?
lisemyon
reviewed
Jul 20, 2023
lisemyon
reviewed
Jul 20, 2023
sidorov-panda
changed the base branch from
feature/pwn-8165-striga
to
feature/PWN-9256
lisemyon
reviewed
Jul 20, 2023
| @@ -17,4 +19,7 @@ public protocol BankTransferUserDataRepository { | |||
| func clearCache() async | |||
|
|
|||
| func getWallet(userId: String) async throws -> UserWallet? | |||
|
|
|||
| func withdrawalInfo() async throws -> WithdrawalInfo? | |||
There was a problem hiding this comment.
get probably as other methods
lisemyon
reviewed
Jul 20, 2023
| @@ -22,6 +23,10 @@ public protocol BankTransferService<Provider> where Provider: BankTransferUserDa | |||
| func resendSMS() async throws | |||
|
|
|||
| func getKYCToken() async throws -> String | |||
|
|
|||
| // WithdrowalProvider | |||
There was a problem hiding this comment.
not a part of WithdrowalProvider i guess
lisemyon
reviewed
Jul 20, 2023
|
|
||
| public func withdrawalInfo() async throws -> Provider.WithdrawalInfo? { | ||
| try await repository.withdrawalInfo() | ||
|
|
lisemyon
reviewed
Jul 20, 2023
| public struct StrigaWithdrawalInfo: Codable { | ||
| public var IBAN: String? | ||
| public var BIC: String? | ||
| public var receiver: String |
lisemyon
reviewed
Jul 20, 2023
| @@ -88,6 +99,8 @@ extension StrigaLocalProviderImpl: StrigaLocalProvider { | |||
| case registration | |||
| case account | |||
| case whitelisted | |||
| case withdrawalInfo | |||
|
|
|||
lisemyon
reviewed
Jul 20, 2023
| @@ -412,3 +412,21 @@ private extension UserWallet { | |||
| self.accounts = UserAccounts(eur: eur, usdc: usdc) | |||
| } | |||
| } | |||
|
|
|||
| extension StrigaBankTransferUserDataRepository { | |||
There was a problem hiding this comment.
might wanna put a mark on it? MARK: - Withdrawal
lisemyon
reviewed
Jul 20, 2023
| @@ -42,6 +42,8 @@ final class BankTransferClaimCoordinator: Coordinator<BankTransferClaimCoordinat | |||
| override func start() -> AnyPublisher<BankTransferClaimCoordinatorResult, Never> { | |||
| // Start OTP Coordinator | |||
| bankTransferService.value.state | |||
| .prefix(1) | |||
lisemyon
reviewed
Jul 20, 2023
| submitLabel: .next | ||
| ) | ||
| } | ||
| Text("Your bank account name must match the name registered to your Key App account") |
lisemyon
reviewed
Jul 20, 2023
| } | ||
| } | ||
|
|
||
| //struct WithdrawView_Previews: PreviewProvider { |
There was a problem hiding this comment.
remove if it can be used?
lisemyon
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link jira to issue
https://p2pvalidator.atlassian.net/browse/PWN-9260
Description of the changes