Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/keyappkit/analyticsmanager #1519

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

bigearsenal
Copy link
Collaborator

@bigearsenal bigearsenal commented Jul 28, 2023

Description of the changes

  • Move Entire KeyApp's AnalyticsManager to AnalyticsManager package.
  • Run swiftformat
  • Add EventTests and ProvidersTests for normal and special events.
  • Add requirement of AnalyticsManagerUnitTests to ci

* develop:
  feat: enable some tests
  fix: test cases

# Conflicts:
#	.github/workflows/key-app-kit-unit-test.yml
* develop:
  fix(keyappkit): KeyAppKit schemes
* develop:
  feat: remove SendTests
  feat: Send as SendViaLink
* develop: (25 commits)
  fix: FakeTransactionErrorType
  fix
  fix
  feat:(token): revert fixing price
  refactor: remove print statement
  feat: update Kingfisher
  feat(swap): fix choose list
  feat(price): pull to refresh to clear cache
  feat(price): add options
  feat: downgrade swift-tools-version
  feat: downgrade swift-tools-version
  feat: fix wrong mint of native solana returned from server
  feat(user-action): optimize updating
  fix: remove dust from display
  fix: switch to RunLoop.main from DispatchQueue.main in tab bar
  fix: set roundingMode = .down
  fix: prevent excessive fetching on tab bar
  feat(home): fix hidden token
  feat(home): fix
  fix: remove hardcode
  ...
@bigearsenal bigearsenal merged commit 900f13e into develop Aug 2, 2023
4 checks passed
@bigearsenal bigearsenal deleted the refactor/keyappkit/analyticsmanager branch August 2, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant