[PWN-9575] Feature/pwn 9575 #1559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigearsenal
reviewed
Aug 9, 2023
| Action: KeyAppStateMachine.Action, | ||
| Dispatcher: KeyAppStateMachine.Dispatcher<State, Action> | ||
| > { | ||
| public actor StateMachine<Dispatcher> where Dispatcher: KeyAppStateMachine.Dispatcher { |
| @@ -8,6 +8,8 @@ public protocol Dispatcher<State, Action> { | |||
| associatedtype State: KeyAppStateMachine.State | |||
| associatedtype Action: KeyAppStateMachine.Action | |||
|
|
|||
| func onEnter(currentState: State) | |||
There was a problem hiding this comment.
Remove onEnter, as actionWillBeginDispatching already handled this case
| // MARK: - Dependencies | ||
|
|
||
| /// Dispatcher that controls dispatching actions | ||
| private let dispatcher: Dispatcher | ||
| let dispatcher: Dispatcher |
There was a problem hiding this comment.
Reverse scope since these properties are used nowhere else
|
|
||
| stateSubject.sink { state in | ||
| dispatcher.onEnter(currentState: state) | ||
| }.store(in: &subscriptions) |
|
|
||
| case calculating | ||
|
|
||
| case receiveError(input: NSendInput, output: NSendOutput?, error: NSendError) |
There was a problem hiding this comment.
calculate, calculating, recieveError should be removed alongside with onEnter
| @@ -51,6 +51,8 @@ class RecruitmentDispatcher: Dispatcher { | |||
| } | |||
| } | |||
|
|
|||
| func onEnter(currentState _: RecruitmentState) {} | |||
bigearsenal
reviewed
Aug 9, 2023
| private var currentTask: Task<Void, Never>? | ||
| var currentTask: Task<Void, Never>? | ||
|
|
||
| var subscriptions: [AnyCancellable] = [] |
There was a problem hiding this comment.
subscriptions need to be removed too when onEnter is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link jira to issue
https://p2pvalidator.atlassian.net/browse/PWN-9575
Description of the changes