Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition during loading tokens #1704

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Fix race condition during loading tokens #1704

merged 5 commits into from
Feb 16, 2024

Conversation

TrGiLong
Copy link
Collaborator

Description of the changes

Copy link

Thank you for your contribution! We detected unformatted code and fixed them for you here: #1705

return
}

setupTask = Task {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since setupTask store strong self and self stores setupTask, there will be retain cycle here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setupTask = nil after running

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just capture [weak self]?

Copy link

Thank you for your contribution! We detected unformatted code and fixed them for you here: #1705

🚧 Correct format for feature/pwn-976
@lisemyon lisemyon merged commit e9e7d00 into develop Feb 16, 2024
2 of 4 checks passed
@lisemyon lisemyon deleted the feature/pwn-976 branch February 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants