Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a random name for in-memory database and set cache to shared by default #595

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Nov 16, 2023

This is a fix around an issue with SQLite / sqlx launchbadge/sqlx#2510 which corrupts our in-memory databases sometimes.

Closes #568

📋 Checklist

  • Add tests that cover your changes
  • Add this PR to the Unreleased section in CHANGELOG.md
  • Link this PR to any issues it closes
  • New files contain a SPDX license header

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efe445c) 92.75% compared to head (a27d312) 92.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   92.75%   92.76%           
=======================================
  Files         106      106           
  Lines       18558    18558           
=======================================
+ Hits        17214    17215    +1     
+ Misses       1344     1343    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adzialocha adzialocha changed the title Generate a random name for in-memory database Generate a random name for in-memory database and set cache to shared by default Nov 16, 2023
@adzialocha adzialocha marked this pull request as ready for review November 16, 2023 21:08
@adzialocha adzialocha merged commit 1d32831 into main Nov 16, 2023
10 checks passed
@adzialocha adzialocha deleted the fix-sqlite-memory-leakage branch November 16, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-Memory SQLite database drops data for unknown reasons
1 participant