Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes https://github.com/p4lang/p4runtime/issues/439 #440

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fixes https://github.com/p4lang/p4runtime/issues/439 #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/any-branch-uploads.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
docker run -v `pwd`/docs/v1:/usr/src/p4-spec p4lang/p4rt-madoko:latest make
ls docs/v1/build
- name: Upload spec to S3 if needed
if: ${{ github.actor != 'dependabot[bot]' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could condition the whole job instead of just this step:

if: ${{ github.repository == 'p4lang/p4runtime' && github.actor != 'dependabot[bot]' }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of that, but then decided it wouldn't hurt to do the build part and just skip the publishing, to get more "coverage" (although it might be redundant with other workflows). What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think strongly about it. Dependabot PRs should have no impact on spec generation, but it's not like we have a high volume of such PRs anyway.

uses: jakejarvis/[email protected]
with:
args: --acl public-read --follow-symlinks --delete
Expand Down