Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different meter types. #484

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

jonathan-dilorenzo
Copy link
Contributor

@jonathan-dilorenzo jonathan-dilorenzo commented Jun 18, 2024

From a new branch because I couldn't figure out how to update PR #473. See that PR for more information.

@jonathan-dilorenzo jonathan-dilorenzo added the 1.4.0 Issues and PRs that we want to go into 1.4.0 label Jun 18, 2024
Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on my end. Can we get a second review, perhaps from @chrispsommers or @jafingerhut?

docs/v1/P4Runtime-Spec.mdk Outdated Show resolved Hide resolved
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrispsommers chrispsommers merged commit 48e9ce8 into main Aug 9, 2024
5 checks passed
@chrispsommers chrispsommers deleted the add_new_meters branch August 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4.0 Issues and PRs that we want to go into 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants