Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #491 update v1.4.0 changelog #496

Closed
wants to merge 10 commits into from
Closed

Fixes #491 update v1.4.0 changelog #496

wants to merge 10 commits into from

Conversation

chrispsommers
Copy link
Collaborator

I generated diffs in spec since v1.3.0 via following command line, which I used as a guide to update the 1.4.0 changes section:

git diff v1.3.0 HEAD ./docs/v1/P4Runtime-Spec.mdk > v1.3.0-spec-diffs.txt

duskmoon314 and others added 10 commits June 6, 2024 18:30
@duskmoon314
Clarify wildcard read of counter and meter (p4lang#481)
d966be4 
Add 'Otherwise' to clarify how `id` and `index` are used in wildcard
read of counter and meter.

Close p4lang#478
@jonathan-dilorenzo
Remove license symlink since it's causing build issues for some githu…
6e8c018 
…b build tools pulling in the new dependency. (p4lang#488)
@jonathan-dilorenzo
Add support for different meter types. (p4lang#484)
48e9ce8 
* Add all changes from PR#473

* Add generated files.

* Remove redundant paragraph.

* Add note about how changing MeterConfig is a non-breaking change.
@smolkaj
Remove accidental optional keyword. (p4lang#494)
d175898 
Fixes p4lang#482

Signed-off-by: Steffen Smolka <[email protected]>
@fruffy
Add information about the initial default action to tables in the P4I…
ec4eb5e 
…nfo file. (p4lang#486)
@Dscano
Add reference for RFC2697 in bib (p4lang#495)
c143633 
Signed-off-by: Dscano <[email protected]>
Signed-off-by: Davide Scano <[email protected]>
@chrispsommers
Merge remote-tracking branch 'origin' into version-1.4.0-rc
6b852f8
@chrispsommers
Update 1.4.0 changelog per p4lang#491
5ff4635 
Signed-off-by: chris <[email protected]>
@chrispsommers
Accentuate protobuf update procedure in README.
78d0ddf
@chrispsommers
Fix section refs.
04fdf6c
@chrispsommers chrispsommers self-assigned this Aug 30, 2024
@chrispsommers chrispsommers changed the base branch from main to version-1.4.0-rc August 30, 2024 22:27
@chrispsommers chrispsommers marked this pull request as draft August 30, 2024 22:29
smolkaj
smolkaj reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@smolkaj smolkaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused -- the diff does not look like an update to the changelog? I see changes across README.md, the spec, and generated python files. I do not see v1.3.0-spec-diffs.txt?
image

@chrispsommers
Copy link
Collaborator Author

chrispsommers commented Sep 3, 2024 •
edited
Loading

Something went wrong with this MR, closing and will re-do.
[Update - rechecked the MR, it is OK AFAIK.]
@smolkaj the changelog is in the spec itself near the bottom, e.g. line 6548

Unfortunately this MR combines accumulated syncs to main along with the changes of interest. If you like I could do two separate MRs to sync to main, then add Changelog.

@chrispsommers chrispsommers reopened this Sep 3, 2024
@chrispsommers chrispsommers mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smolkaj smolkaj smolkaj left review comments

Assignees

@chrispsommers chrispsommers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrispsommers @smolkaj @duskmoon314 @jonathan-dilorenzo @fruffy @Dscano