Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just a cleanup of some useless crap #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

just a cleanup of some useless crap #213

wants to merge 1 commit into from

Conversation

alextwothousand
Copy link

mysql auto_reconnects by default and there is no point saving player's data ongamemodeexit

mysql auto_reconnects by default and there is no point saving player's data ongamemodeexit
@maddinat0r
Copy link
Collaborator

Thanks for the PR!
Could you also do the same change in the login_system-cache.pwn file?

@2Col
Copy link

2Col commented May 9, 2019

What about SetPlayerPos and SetPlayerFacingAngle in OnPlayerSpawn? If SetSpawnInfo is called before spawning player are those functions really necessary?

@George480
Copy link

George480 commented May 9, 2019

If I type exit in console, it does not call OnPlayerDisconnect but does call OnGameModeExit. Many servers do not use gmx but exit and start server up immediately.

What about SetPlayerPos and SetPlayerFacingAngle in OnPlayerSpawn? If SetSpawnInfo is called before spawning player are those functions really necessary?

What about the interior? Changing the interior after being spawned will still be too late and players will fall down.

@alextwothousand
Copy link
Author

alextwothousand commented May 13, 2019

I will make these changes as soon as I get home. Thank you in advance.

@Vladik01-11
Copy link

I will make these changes as soon as I get home. Thank you in advance.

There are rumors that he is still going home 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants