Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the console messaging on starting the app to avoid confusion. #292

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Improve the console messaging on starting the app to avoid confusion. #292

merged 2 commits into from
Nov 15, 2023

Conversation

sangitamane
Copy link
Member

No description provided.

@danyalaytekin danyalaytekin added this to the 4.3 milestone Nov 10, 2023
@danyalaytekin
Copy link
Member

danyalaytekin commented Nov 15, 2023 •
edited
Loading

Hey @sangitamane, this looks helpful - it would have helped me to understand the IPV6 issue I experienced with pa11y-webservice earlier.

I've made a couple of revisions to present the intended URL alongside the actual URL reported. Please review and let me know whether you're happy with the changes.

It also resolves the confusing placement (in main) of some of the webservice's logging into the dashboard's logging.

@danyalaytekin
Copy link
Member

main's logging PR's original logging Revised logging
image image image

sangitamane
sangitamane commented Nov 15, 2023
View reviewed changes
Copy link
Member Author

@sangitamane sangitamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like I can't approve this!

@danyalaytekin
Copy link
Member

😄 Thanks for the soft approval though. @jpw @hollsk @josebolos what do you think?

@danyalaytekin
Copy link
Member

Tried approving but, as is logical, it didn't work. Well played, repo settings, well played 👀

hollsk
hollsk approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH YEAH this has been annoying me for AGES but not enough for me to do anything about it, vg update 🙈 😆

thanks both! 🙏

@danyalaytekin danyalaytekin merged commit 8145069 into main Nov 15, 2023
4 checks passed
@danyalaytekin danyalaytekin deleted the console-msg-fix branch November 15, 2023 09:26
@danyalaytekin danyalaytekin mentioned this pull request Mar 21, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollsk hollsk hollsk approved these changes

@danyalaytekin danyalaytekin danyalaytekin approved these changes

@jpw jpw Awaiting requested review from jpw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sangitamane @danyalaytekin @hollsk